From 135100a472c1fd261046bda51c897ea58a73d038 Mon Sep 17 00:00:00 2001
From: Chen Chengjun <chenchengjun.ccj@antgroup.com>
Date: Mon, 17 Mar 2025 10:35:31 +0800
Subject: [PATCH] Modify the getting-VMAR usages in other syscalls

---
 kernel/src/process/process_vm/heap.rs |  6 +++---
 kernel/src/syscall/brk.rs             |  2 +-
 kernel/src/syscall/madvise.rs         |  3 ++-
 kernel/src/syscall/mmap.rs            |  3 ++-
 kernel/src/syscall/mprotect.rs        |  3 ++-
 kernel/src/syscall/munmap.rs          |  3 ++-
 kernel/src/syscall/pread64.rs         |  7 ++-----
 kernel/src/syscall/preadv.rs          |  6 ++++--
 kernel/src/syscall/pwrite64.rs        |  7 ++-----
 kernel/src/syscall/pwritev.rs         |  6 ++++--
 kernel/src/syscall/read.rs            |  7 ++-----
 kernel/src/syscall/recvfrom.rs        |  6 ++----
 kernel/src/syscall/recvmsg.rs         |  3 ++-
 kernel/src/syscall/sendmsg.rs         |  3 ++-
 kernel/src/syscall/sendto.rs          |  6 ++----
 kernel/src/syscall/write.rs           |  7 ++-----
 kernel/src/util/iovec.rs              | 12 ++++++------
 kernel/src/util/net/socket.rs         | 14 ++++++++++----
 18 files changed, 52 insertions(+), 52 deletions(-)

diff --git a/kernel/src/process/process_vm/heap.rs b/kernel/src/process/process_vm/heap.rs
index 3eb622b1..24d907b3 100644
--- a/kernel/src/process/process_vm/heap.rs
+++ b/kernel/src/process/process_vm/heap.rs
@@ -65,9 +65,9 @@ impl Heap {
         Ok(())
     }
 
-    pub fn brk(&self, new_heap_end: Option<Vaddr>) -> Result<Vaddr> {
-        let current = current!();
-        let root_vmar = current.root_vmar();
+    pub fn brk(&self, new_heap_end: Option<Vaddr>, ctx: &Context) -> Result<Vaddr> {
+        let user_space = ctx.user_space();
+        let root_vmar = user_space.root_vmar();
         match new_heap_end {
             None => Ok(self.current_heap_end.load(Ordering::Relaxed)),
             Some(new_heap_end) => {
diff --git a/kernel/src/syscall/brk.rs b/kernel/src/syscall/brk.rs
index 80f96452..5e3da976 100644
--- a/kernel/src/syscall/brk.rs
+++ b/kernel/src/syscall/brk.rs
@@ -11,7 +11,7 @@ pub fn sys_brk(heap_end: u64, ctx: &Context) -> Result<SyscallReturn> {
     };
     debug!("new heap end = {:x?}", heap_end);
     let user_heap = ctx.process.heap();
-    let new_heap_end = user_heap.brk(new_heap_end)?;
+    let new_heap_end = user_heap.brk(new_heap_end, ctx)?;
 
     Ok(SyscallReturn::Return(new_heap_end as _))
 }
diff --git a/kernel/src/syscall/madvise.rs b/kernel/src/syscall/madvise.rs
index c7506e97..6e4bdb51 100644
--- a/kernel/src/syscall/madvise.rs
+++ b/kernel/src/syscall/madvise.rs
@@ -51,7 +51,8 @@ pub fn sys_madvise(
 }
 
 fn madv_free(start: Vaddr, end: Vaddr, ctx: &Context) -> Result<()> {
-    let root_vmar = ctx.process.root_vmar();
+    let user_space = ctx.user_space();
+    let root_vmar = user_space.root_vmar();
     let advised_range = start..end;
     let _ = root_vmar.remove_mapping(advised_range);
 
diff --git a/kernel/src/syscall/mmap.rs b/kernel/src/syscall/mmap.rs
index 7db39416..5ebba19e 100644
--- a/kernel/src/syscall/mmap.rs
+++ b/kernel/src/syscall/mmap.rs
@@ -91,7 +91,8 @@ fn do_sys_mmap(
         vm_perms
     };
 
-    let root_vmar = ctx.process.root_vmar();
+    let user_space = ctx.user_space();
+    let root_vmar = user_space.root_vmar();
     let vm_map_options = {
         let mut options = root_vmar.new_map(len, vm_perms)?;
         let flags = option.flags;
diff --git a/kernel/src/syscall/mprotect.rs b/kernel/src/syscall/mprotect.rs
index f55c5f8d..144c18b7 100644
--- a/kernel/src/syscall/mprotect.rs
+++ b/kernel/src/syscall/mprotect.rs
@@ -11,7 +11,8 @@ pub fn sys_mprotect(addr: Vaddr, len: usize, perms: u64, ctx: &Context) -> Resul
         "addr = 0x{:x}, len = 0x{:x}, perms = {:?}",
         addr, len, vm_perms
     );
-    let root_vmar = ctx.process.root_vmar();
+    let user_space = ctx.user_space();
+    let root_vmar = user_space.root_vmar();
 
     // According to linux behavior,
     // <https://elixir.bootlin.com/linux/v6.0.9/source/mm/mprotect.c#L681>,
diff --git a/kernel/src/syscall/munmap.rs b/kernel/src/syscall/munmap.rs
index 7ff04aca..7b96c3b1 100644
--- a/kernel/src/syscall/munmap.rs
+++ b/kernel/src/syscall/munmap.rs
@@ -18,7 +18,8 @@ pub fn sys_munmap(addr: Vaddr, len: usize, ctx: &Context) -> Result<SyscallRetur
         return_errno_with_message!(Errno::ENOMEM, "munmap len align overflow");
     }
 
-    let root_vmar = ctx.process.root_vmar();
+    let user_space = ctx.user_space();
+    let root_vmar = user_space.root_vmar();
     let len = len.align_up(PAGE_SIZE);
     let end = addr.checked_add(len).ok_or(Error::with_message(
         Errno::EINVAL,
diff --git a/kernel/src/syscall/pread64.rs b/kernel/src/syscall/pread64.rs
index 7366fc57..d12a3547 100644
--- a/kernel/src/syscall/pread64.rs
+++ b/kernel/src/syscall/pread64.rs
@@ -34,11 +34,8 @@ pub fn sys_pread64(
     }
 
     let read_len = {
-        let mut writer = ctx
-            .process
-            .root_vmar()
-            .vm_space()
-            .writer(user_buf_ptr, user_buf_len)?;
+        let user_space = ctx.user_space();
+        let mut writer = user_space.writer(user_buf_ptr, user_buf_len)?;
         file.read_at(offset as usize, &mut writer)?
     };
 
diff --git a/kernel/src/syscall/preadv.rs b/kernel/src/syscall/preadv.rs
index 527c1f41..fd678efb 100644
--- a/kernel/src/syscall/preadv.rs
+++ b/kernel/src/syscall/preadv.rs
@@ -75,7 +75,8 @@ fn do_sys_preadv(
     let mut total_len: usize = 0;
     let mut cur_offset = offset as usize;
 
-    let mut writer_array = VmWriterArray::from_user_io_vecs(ctx, io_vec_ptr, io_vec_count)?;
+    let user_space = ctx.user_space();
+    let mut writer_array = VmWriterArray::from_user_io_vecs(&user_space, io_vec_ptr, io_vec_count)?;
     for writer in writer_array.writers_mut() {
         if !writer.has_avail() {
             continue;
@@ -134,7 +135,8 @@ fn do_sys_readv(
 
     let mut total_len = 0;
 
-    let mut writer_array = VmWriterArray::from_user_io_vecs(ctx, io_vec_ptr, io_vec_count)?;
+    let user_space = ctx.user_space();
+    let mut writer_array = VmWriterArray::from_user_io_vecs(&user_space, io_vec_ptr, io_vec_count)?;
     for writer in writer_array.writers_mut() {
         if !writer.has_avail() {
             continue;
diff --git a/kernel/src/syscall/pwrite64.rs b/kernel/src/syscall/pwrite64.rs
index 64c4927a..fa64c4bd 100644
--- a/kernel/src/syscall/pwrite64.rs
+++ b/kernel/src/syscall/pwrite64.rs
@@ -33,11 +33,8 @@ pub fn sys_pwrite64(
         return_errno_with_message!(Errno::EINVAL, "offset + user_buf_len overflow");
     }
 
-    let mut reader = ctx
-        .process
-        .root_vmar()
-        .vm_space()
-        .reader(user_buf_ptr, user_buf_len)?;
+    let user_space = ctx.user_space();
+    let mut reader = user_space.reader(user_buf_ptr, user_buf_len)?;
     let write_len = file.write_at(offset as _, &mut reader)?;
     Ok(SyscallReturn::Return(write_len as _))
 }
diff --git a/kernel/src/syscall/pwritev.rs b/kernel/src/syscall/pwritev.rs
index b44aa6c5..6a506c30 100644
--- a/kernel/src/syscall/pwritev.rs
+++ b/kernel/src/syscall/pwritev.rs
@@ -77,7 +77,8 @@ fn do_sys_pwritev(
     let mut total_len: usize = 0;
     let mut cur_offset = offset as usize;
 
-    let mut reader_array = VmReaderArray::from_user_io_vecs(ctx, io_vec_ptr, io_vec_count)?;
+    let user_space = ctx.user_space();
+    let mut reader_array = VmReaderArray::from_user_io_vecs(&user_space, io_vec_ptr, io_vec_count)?;
     for reader in reader_array.readers_mut() {
         if !reader.has_remain() {
             continue;
@@ -127,7 +128,8 @@ fn do_sys_writev(
 
     let mut total_len = 0;
 
-    let mut reader_array = VmReaderArray::from_user_io_vecs(ctx, io_vec_ptr, io_vec_count)?;
+    let user_space = ctx.user_space();
+    let mut reader_array = VmReaderArray::from_user_io_vecs(&user_space, io_vec_ptr, io_vec_count)?;
     for reader in reader_array.readers_mut() {
         if !reader.has_remain() {
             continue;
diff --git a/kernel/src/syscall/read.rs b/kernel/src/syscall/read.rs
index 3635cbdf..146a9afa 100644
--- a/kernel/src/syscall/read.rs
+++ b/kernel/src/syscall/read.rs
@@ -25,11 +25,8 @@ pub fn sys_read(
     // the file descriptor. If no errors detected, return 0 successfully.
     let read_len = {
         if buf_len != 0 {
-            let mut writer = ctx
-                .process
-                .root_vmar()
-                .vm_space()
-                .writer(user_buf_addr, buf_len)?;
+            let user_space = ctx.user_space();
+            let mut writer = user_space.writer(user_buf_addr, buf_len)?;
             file.read(&mut writer)
         } else {
             file.read_bytes(&mut [])
diff --git a/kernel/src/syscall/recvfrom.rs b/kernel/src/syscall/recvfrom.rs
index 47c8cfb2..5643b83b 100644
--- a/kernel/src/syscall/recvfrom.rs
+++ b/kernel/src/syscall/recvfrom.rs
@@ -24,10 +24,8 @@ pub fn sys_recvfrom(
     let file = get_file_fast!(&mut file_table, sockfd);
     let socket = file.as_socket_or_err()?;
 
-    let mut writers = {
-        let vm_space = ctx.process.root_vmar().vm_space();
-        vm_space.writer(buf, len)?
-    };
+    let user_space = ctx.user_space();
+    let mut writers = user_space.writer(buf, len)?;
 
     let (recv_size, message_header) =
         socket
diff --git a/kernel/src/syscall/recvmsg.rs b/kernel/src/syscall/recvmsg.rs
index 9f76d61f..93ffcf0e 100644
--- a/kernel/src/syscall/recvmsg.rs
+++ b/kernel/src/syscall/recvmsg.rs
@@ -27,7 +27,8 @@ pub fn sys_recvmsg(
     let socket = file.as_socket_or_err()?;
 
     let (total_bytes, message_header) = {
-        let mut io_vec_writer = c_user_msghdr.copy_writer_array_from_user(ctx)?;
+        let user_space = ctx.user_space();
+        let mut io_vec_writer = c_user_msghdr.copy_writer_array_from_user(&user_space)?;
         socket
             .recvmsg(&mut io_vec_writer, flags)
             .map_err(|err| match err.error() {
diff --git a/kernel/src/syscall/sendmsg.rs b/kernel/src/syscall/sendmsg.rs
index 46b45749..212b9beb 100644
--- a/kernel/src/syscall/sendmsg.rs
+++ b/kernel/src/syscall/sendmsg.rs
@@ -26,9 +26,10 @@ pub fn sys_sendmsg(
     let file = get_file_fast!(&mut file_table, sockfd);
     let socket = file.as_socket_or_err()?;
 
+    let user_space = ctx.user_space();
     let (mut io_vec_reader, message_header) = {
         let addr = c_user_msghdr.read_socket_addr_from_user()?;
-        let io_vec_reader = c_user_msghdr.copy_reader_array_from_user(ctx)?;
+        let io_vec_reader = c_user_msghdr.copy_reader_array_from_user(&user_space)?;
 
         let control_message = {
             if c_user_msghdr.msg_control != 0 {
diff --git a/kernel/src/syscall/sendto.rs b/kernel/src/syscall/sendto.rs
index a213969e..44f0be42 100644
--- a/kernel/src/syscall/sendto.rs
+++ b/kernel/src/syscall/sendto.rs
@@ -32,10 +32,8 @@ pub fn sys_sendto(
 
     let message_header = MessageHeader::new(socket_addr, None);
 
-    let mut reader = {
-        let vm_space = ctx.process.root_vmar().vm_space();
-        vm_space.reader(buf, len)?
-    };
+    let user_space = ctx.user_space();
+    let mut reader = user_space.reader(buf, len)?;
     let send_size = socket
         .sendmsg(&mut reader, message_header, flags)
         .map_err(|err| match err.error() {
diff --git a/kernel/src/syscall/write.rs b/kernel/src/syscall/write.rs
index 5327f73d..dd56934d 100644
--- a/kernel/src/syscall/write.rs
+++ b/kernel/src/syscall/write.rs
@@ -25,11 +25,8 @@ pub fn sys_write(
     // the file descriptor. If no errors detected, return 0 successfully.
     let write_len = {
         if user_buf_len != 0 {
-            let mut reader = ctx
-                .process
-                .root_vmar()
-                .vm_space()
-                .reader(user_buf_ptr, user_buf_len)?;
+            let user_space = ctx.user_space();
+            let mut reader = user_space.reader(user_buf_ptr, user_buf_len)?;
             file.write(&mut reader)
         } else {
             file.write_bytes(&[])
diff --git a/kernel/src/util/iovec.rs b/kernel/src/util/iovec.rs
index 402ac6c8..983d5116 100644
--- a/kernel/src/util/iovec.rs
+++ b/kernel/src/util/iovec.rs
@@ -55,12 +55,12 @@ impl IoVec {
 
 /// The util function for create [`VmReader`]/[`VmWriter`]s.
 fn copy_iovs_and_convert<'a, T: 'a>(
-    ctx: &'a Context,
+    user_space: &'a CurrentUserSpace<'a>,
     start_addr: Vaddr,
     count: usize,
     convert_iovec: impl Fn(&IoVec, &'a VmSpace) -> Result<T>,
 ) -> Result<Box<[T]>> {
-    let vm_space = ctx.process.root_vmar().vm_space();
+    let vm_space = user_space.root_vmar().vm_space();
 
     let mut v = Vec::with_capacity(count);
     for idx in 0..count {
@@ -96,11 +96,11 @@ pub struct VmWriterArray<'a>(Box<[VmWriter<'a>]>);
 impl<'a> VmReaderArray<'a> {
     /// Creates a new `IoVecReader` from user-provided io vec buffer.
     pub fn from_user_io_vecs(
-        ctx: &'a Context<'a>,
+        user_space: &'a CurrentUserSpace<'a>,
         start_addr: Vaddr,
         count: usize,
     ) -> Result<Self> {
-        let readers = copy_iovs_and_convert(ctx, start_addr, count, IoVec::reader)?;
+        let readers = copy_iovs_and_convert(user_space, start_addr, count, IoVec::reader)?;
         Ok(Self(readers))
     }
 
@@ -113,11 +113,11 @@ impl<'a> VmReaderArray<'a> {
 impl<'a> VmWriterArray<'a> {
     /// Creates a new `IoVecWriter` from user-provided io vec buffer.
     pub fn from_user_io_vecs(
-        ctx: &'a Context<'a>,
+        user_space: &'a CurrentUserSpace<'a>,
         start_addr: Vaddr,
         count: usize,
     ) -> Result<Self> {
-        let writers = copy_iovs_and_convert(ctx, start_addr, count, IoVec::writer)?;
+        let writers = copy_iovs_and_convert(user_space, start_addr, count, IoVec::writer)?;
         Ok(Self(writers))
     }
 
diff --git a/kernel/src/util/net/socket.rs b/kernel/src/util/net/socket.rs
index e1990adc..b83005b4 100644
--- a/kernel/src/util/net/socket.rs
+++ b/kernel/src/util/net/socket.rs
@@ -112,11 +112,17 @@ impl CUserMsgHdr {
         Ok(())
     }
 
-    pub fn copy_reader_array_from_user<'a>(&self, ctx: &'a Context) -> Result<VmReaderArray<'a>> {
-        VmReaderArray::from_user_io_vecs(ctx, self.msg_iov, self.msg_iovlen as usize)
+    pub fn copy_reader_array_from_user<'a>(
+        &self,
+        user_space: &'a CurrentUserSpace<'a>,
+    ) -> Result<VmReaderArray<'a>> {
+        VmReaderArray::from_user_io_vecs(user_space, self.msg_iov, self.msg_iovlen as usize)
     }
 
-    pub fn copy_writer_array_from_user<'a>(&self, ctx: &'a Context) -> Result<VmWriterArray<'a>> {
-        VmWriterArray::from_user_io_vecs(ctx, self.msg_iov, self.msg_iovlen as usize)
+    pub fn copy_writer_array_from_user<'a>(
+        &self,
+        user_space: &'a CurrentUserSpace<'a>,
+    ) -> Result<VmWriterArray<'a>> {
+        VmWriterArray::from_user_io_vecs(user_space, self.msg_iov, self.msg_iovlen as usize)
     }
 }