Samuka007/asterinas
1
0
Fork 0
mirror of https://github.com/asterinas/asterinas.git synced 2025-06-25 02:13:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix unexpected unlock of mutexes

Browse Source
This commit is contained in:
徐启航
2023-11-17 17:44:33 +08:00
committed by Tate, Hongliang Tian
parent 9e09196043
commit 3790efb0d9
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
framework/jinux-frame/src/sync/mutex.rs
View File

@ -31,7 +31,13 @@ impl<T> Mutex<T> {
/// Try Acquire the mutex immedidately. /// Try Acquire the mutex immedidately.
pub fn try_lock(&self) -> Option<MutexGuard<T>> { pub fn try_lock(&self) -> Option<MutexGuard<T>> {
self.acquire_lock().then_some(MutexGuard { mutex: self }) // Cannot be reduced to `then_some`, or the possible dropping of the temporary
// guard will cause an unexpected unlock.
//
// TODO: Remove the lint suppression when the false positive warning is fixed
// upstream.
#[allow(clippy::unnecessary_lazy_evaluations)]
self.acquire_lock().then(|| MutexGuard { mutex: self })
} }
/// Release the mutex and wake up one thread which is blocked on this mutex. /// Release the mutex and wake up one thread which is blocked on this mutex.