From 58948d498c2875ecf85b8721f38715f6d973e49a Mon Sep 17 00:00:00 2001 From: Ruihan Li Date: Thu, 21 Dec 2023 02:52:32 +0800 Subject: [PATCH] Remove incorrect logic about TCP's HUP/RDHUP events Changes in this commit were suggested by @StevenJiang1110. HUP/RDHUP events are not correctly updated for TCP sockets (#529), so we are removing this to avoid further confusion. --- .../libs/jinux-std/src/net/iface/any_socket.rs | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/services/libs/jinux-std/src/net/iface/any_socket.rs b/services/libs/jinux-std/src/net/iface/any_socket.rs index 020fe5692..f32c2e09f 100644 --- a/services/libs/jinux-std/src/net/iface/any_socket.rs +++ b/services/libs/jinux-std/src/net/iface/any_socket.rs @@ -193,20 +193,6 @@ fn update_tcp_socket_state(socket: &RawTcpSocket, pollee: &Pollee) { } else { pollee.del_events(IoEvents::OUT); } - - if socket.may_recv() { - pollee.del_events(IoEvents::RDHUP); - } else { - // The receice half was closed - pollee.add_events(IoEvents::RDHUP); - } - - if socket.is_open() { - pollee.del_events(IoEvents::HUP); - } else { - // The socket is closed - pollee.add_events(IoEvents::HUP); - } } fn update_udp_socket_state(socket: &RawUdpSocket, pollee: &Pollee) {