Samuka007/asterinas
1
0
Fork 0
mirror of https://github.com/asterinas/asterinas.git synced 2025-06-29 04:13:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix DMA coherent

Browse Source
This commit is contained in:
Shaocong Sun
2024-06-03 15:27:28 +08:00
committed by Tate, Hongliang Tian
parent cea4fd7777
commit 69f0954271
1 changed files with 21 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
framework/aster-frame/src/mm/dma/dma_stream.rs
View File

@ -1,7 +1,7 @@
// SPDX-License-Identifier: MPL-2.0 // SPDX-License-Identifier: MPL-2.0
use alloc::sync::Arc; use alloc::sync::Arc;
use core::{arch::x86_64::_mm_clflush, ops::Range}; use core::ops::Range;
#[cfg(feature = "intel_tdx")] #[cfg(feature = "intel_tdx")]
use ::tdx_guest::tdx_is_enabled; use ::tdx_guest::tdx_is_enabled;
@ -132,8 +132,14 @@ impl DmaStream {
/// ///
/// [`read_bytes`]: Self::read_bytes /// [`read_bytes`]: Self::read_bytes
/// [`write_bytes`]: Self::write_bytes /// [`write_bytes`]: Self::write_bytes
pub fn sync(&self, byte_range: Range<usize>) -> Result<(), Error> { pub fn sync(&self, _byte_range: Range<usize>) -> Result<(), Error> {
if byte_range.end > self.nbytes() { cfg_if::cfg_if! {
if #[cfg(target_arch = "x86_64")]{
// The streaming DMA mapping in x86_64 is cache coherent, and does not require synchronization.
// Reference: <https://lwn.net/Articles/855328/>, <https://lwn.net/Articles/2265/>
Ok(())
} else {
if _byte_range.end > self.nbytes() {
return Err(Error::InvalidArgs); return Err(Error::InvalidArgs);
} }
if self.inner.is_cache_coherent { if self.inner.is_cache_coherent {
@ -141,15 +147,15 @@ impl DmaStream {
} }
let start_va = self.inner.vm_segment.as_ptr(); let start_va = self.inner.vm_segment.as_ptr();
// TODO: Query the CPU for the cache line size via CPUID, we use 64 bytes as the cache line size here. // TODO: Query the CPU for the cache line size via CPUID, we use 64 bytes as the cache line size here.
for i in byte_range.step_by(64) { for i in _byte_range.step_by(64) {
// SAFETY: the addresses is limited by a valid `byte_range`. // TODO: Call the cache line flush command in the corresponding architecture.
unsafe { todo!()
_mm_clflush(start_va.wrapping_add(i));
}
} }
Ok(()) Ok(())
} }
} }
}
}
impl HasDaddr for DmaStream { impl HasDaddr for DmaStream {
fn daddr(&self) -> Daddr { fn daddr(&self) -> Daddr {