Refactor semaphore to support atomic semop

kernel/src/ipc/semaphore/system_v/sem.rs

@@ -1,21 +1,19 @@
 // SPDX-License-Identifier: MPL-2.0
 
 use core::{
-    sync::atomic::{AtomicU16, AtomicU32, AtomicU64, Ordering},
+    slice::Iter,
+    sync::atomic::{AtomicU16, Ordering},
     time::Duration,
 };
 
 use ostd::sync::{PreemptDisabled, Waiter, Waker};
 
-use super::sem_set::SEMVMX;
+use super::sem_set::{SemSetInner, SEMVMX};
 use crate::{
     ipc::{key_t, semaphore::system_v::sem_set::sem_sets, IpcFlags},
     prelude::*,
-    process::{Pid, Process},
+    process::Pid,
-    time::{
+    time::{clocks::JIFFIES_TIMER_MANAGER, timer::Timeout},
-        clocks::{RealTimeCoarseClock, JIFFIES_TIMER_MANAGER},
-        timer::Timeout,
-    },
 };
 
 #[derive(Clone, Copy, Debug, Pod)]
@@ -42,7 +40,7 @@ impl SemBuf {
 
 #[repr(u16)]
 #[derive(Debug, TryFromInt, Clone, Copy)]
-enum Status {
+pub enum Status {
     Normal = 0,
     Pending = 1,
     Removed = 2,
@@ -64,18 +62,36 @@ impl AtomicStatus {
     }
 }
 
-struct PendingOp {
+/// Pending atomic semop.
-    sem_buf: SemBuf,
+pub struct PendingOp {
+    sops: Vec<SemBuf>,
     status: Arc<AtomicStatus>,
-    waker: Arc<Waker>,
+    waker: Option<Arc<Waker>>,
     pid: Pid,
-    process: Weak<Process>,
+}
+
+impl PendingOp {
+    pub fn sops_iter(&self) -> Iter<SemBuf> {
+        self.sops.iter()
+    }
+
+    pub fn set_status(&self, status: Status) {
+        self.status.set_status(status);
+    }
+
+    pub fn waker(&self) -> &Option<Arc<Waker>> {
+        &self.waker
+    }
+
+    pub fn pid(&self) -> Pid {
+        self.pid
+    }
 }
 
 impl Debug for PendingOp {
     fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
         f.debug_struct("PendingOp")
-            .field("sem_buf", &self.sem_buf)
+            .field("sops", &self.sops)
             .field("status", &(self.status.status()))
             .field("pid", &self.pid)
             .finish()
@@ -84,252 +100,268 @@ impl Debug for PendingOp {
 
 #[derive(Debug)]
 pub struct Semaphore {
-    val: SpinLock<i32>,
+    val: i32,
     /// PID of the process that last modified semaphore.
     /// - through semop with op != 0
     /// - through semctl with SETVAL and SETALL
     /// - through SEM_UNDO when task exit
-    latest_modified_pid: AtomicU32,
+    latest_modified_pid: Pid,
-    /// Pending alter operations. For each pending operation, it has `sem_op < 0`.
-    pending_alters: SpinLock<LinkedList<PendingOp>>,
-    /// Pending zeros operations. For each pending operation, it has `sem_op = 0`.
-    pending_const: SpinLock<LinkedList<PendingOp>>,
-    /// Last semop time.
-    sem_otime: AtomicU64,
 }
 
 impl Semaphore {
-    pub fn set_val(&self, val: i32, current_pid: Pid) -> Result<()> {
+    pub fn set_val(&mut self, val: i32) {
-        if !(0..SEMVMX).contains(&val) {
+        self.val = val;
-            return_errno!(Errno::ERANGE);
-        }
-
-        let mut current_val = self.val.lock();
-        *current_val = val;
-
-        self.update_pending_ops(current_val, current_pid);
-        Ok(())
     }
 
     pub fn val(&self) -> i32 {
-        *self.val.lock()
+        self.val
     }
 
-    pub fn last_modified_pid(&self) -> Pid {
+    pub fn set_latest_modified_pid(&mut self, pid: Pid) {
-        self.latest_modified_pid.load(Ordering::Relaxed)
+        self.latest_modified_pid = pid;
     }
 
-    pub fn sem_otime(&self) -> Duration {
+    pub fn latest_modified_pid(&self) -> Pid {
-        Duration::from_secs(self.sem_otime.load(Ordering::Relaxed))
+        self.latest_modified_pid
-    }
-
-    pub fn pending_zero_count(&self) -> usize {
-        self.pending_const.lock().len()
-    }
-
-    pub fn pending_alter_count(&self) -> usize {
-        self.pending_alters.lock().len()
-    }
-
-    /// Notifies the semaphore that the semaphore sets it belongs to have been removed.
-    pub(super) fn removed(&self) {
-        let mut pending_alters = self.pending_alters.lock();
-        for pending_alter in pending_alters.iter_mut() {
-            pending_alter.status.set_status(Status::Removed);
-            pending_alter.waker.wake_up();
-        }
-        pending_alters.clear();
-
-        let mut pending_const = self.pending_const.lock();
-        for pending_const in pending_const.iter_mut() {
-            pending_const.status.set_status(Status::Removed);
-            pending_const.waker.wake_up();
-        }
-        pending_const.clear();
     }
 
     pub(super) fn new(val: i32) -> Self {
         Self {
-            val: SpinLock::new(val),
+            val,
-            latest_modified_pid: AtomicU32::new(current!().pid()),
+            latest_modified_pid: current!().pid(),
-            pending_alters: SpinLock::new(LinkedList::new()),
+        }
-            pending_const: SpinLock::new(LinkedList::new()),
-            sem_otime: AtomicU64::new(0),
     }
 }
 
-    fn update_otime(&self) {
+pub fn sem_op(
-        self.sem_otime.store(
+    sem_id: key_t,
-            RealTimeCoarseClock::get().read_time().as_secs(),
+    sops: Vec<SemBuf>,
-            Ordering::Relaxed,
+    timeout: Option<Duration>,
-        );
+    ctx: &Context,
-    }
+) -> Result<()> {
+    debug_assert!(sem_id > 0);
+    debug!("[semop] sops: {:?}", sops);
 
-    fn sem_op(&self, sem_buf: &SemBuf, timeout: Option<Duration>, ctx: &Context) -> Result<()> {
+    let pid = ctx.process.pid();
-        let mut val = self.val.lock();
+    let mut pending_op = PendingOp {
-        let sem_op = sem_buf.sem_op;
+        sops,
-        let current_pid = ctx.process.pid();
+        status: Arc::new(AtomicStatus::new(Status::Pending)),
-
+        waker: None,
-        let flags = IpcFlags::from_bits_truncate(sem_buf.sem_flags as u32);
+        pid,
-        if flags.contains(IpcFlags::SEM_UNDO) {
-            todo!()
-        }
-
-        // Operate val
-        let positive_condition = sem_op.is_positive();
-        let negative_condition = sem_op.is_negative() && sem_op.abs() as i32 <= *val;
-        let zero_condition = sem_op == 0 && *val == 0;
-
-        if positive_condition || negative_condition {
-            let new_val = val
-                .checked_add(i32::from(sem_op))
-                .ok_or(Error::new(Errno::ERANGE))?;
-            if new_val > SEMVMX {
-                return_errno!(Errno::ERANGE);
-            }
-
-            *val = new_val;
-            self.update_pending_ops(val, current_pid);
-            return Ok(());
-        } else if zero_condition {
-            return Ok(());
-        }
-        drop(val);
-
-        // Need to wait for the semaphore
-        if flags.contains(IpcFlags::IPC_NOWAIT) {
-            return_errno!(Errno::EAGAIN);
-        }
-
-        // Add current to pending list
-        let (waiter, waker) = Waiter::new_pair();
-        let status = Arc::new(AtomicStatus::new(Status::Pending));
-        let pending_op = PendingOp {
-            sem_buf: *sem_buf,
-            status: status.clone(),
-            waker: waker.clone(),
-            process: ctx.posix_thread.weak_process(),
-            pid: current_pid,
     };
-        if sem_op == 0 {
+
-            self.pending_const.lock().push_back(pending_op);
+    // TODO: Support permission check
-        } else {
+    warn!("Semaphore operation doesn't support permission check now");
-            self.pending_alters.lock().push_back(pending_op);
+
+    let (alter, dupsop) = get_sops_flags(&pending_op);
+    if dupsop {
+        warn!("Found duplicate sop");
     }
 
-        // Wait
+    let local_sem_sets = sem_sets();
+    let sem_set = local_sem_sets
+        .get(&sem_id)
+        .ok_or(Error::new(Errno::EINVAL))?;
+    let mut inner = sem_set.inner();
+
+    if perform_atomic_semop(&mut inner.sems, &mut pending_op)? {
+        if alter {
+            let wake_queue = do_smart_update(&mut inner, &pending_op);
+            for wake_op in wake_queue {
+                wake_op.set_status(Status::Normal);
+                if let Some(waker) = wake_op.waker {
+                    waker.wake_up();
+                }
+            }
+        }
+
+        sem_set.update_otime();
+        return Ok(());
+    }
+
+    // Prepare to wait
+    let status = pending_op.status.clone();
+    let (waiter, waker) = Waiter::new_pair();
+
+    // Check if timeout exists to avoid calling `Arc::clone()`
     if let Some(timeout) = timeout {
+        pending_op.waker = Some(waker.clone());
+
         let jiffies_timer = JIFFIES_TIMER_MANAGER.get().unwrap().create_timer(move || {
             waker.wake_up();
         });
         jiffies_timer.set_timeout(Timeout::After(timeout));
+    } else {
+        pending_op.waker = Some(waker);
     }
-        waiter.wait();
 
-        // Check status and return
+    if alter {
+        inner.pending_alter.push_back(pending_op);
+    } else {
+        inner.pending_const.push_back(pending_op);
+    }
+
+    drop(inner);
+    drop(local_sem_sets);
+
+    waiter.wait();
     match status.status() {
         Status::Normal => Ok(()),
         Status::Removed => Err(Error::new(Errno::EIDRM)),
         Status::Pending => {
-                let mut pending_ops = if sem_op == 0 {
+            // FIXME: Getting sem_sets maybe time-consuming.
-                    self.pending_const.lock()
+            let sem_sets = sem_sets();
+            let sem_set = sem_sets.get(&sem_id).ok_or(Error::new(Errno::EINVAL))?;
+            let mut inner = sem_set.inner();
+
+            let pending_ops = if alter {
+                &mut inner.pending_alter
             } else {
-                    self.pending_alters.lock()
+                &mut inner.pending_const
             };
-                pending_ops.retain(|op| op.pid != current_pid);
+            pending_ops.retain(|op| op.pid != pid);
+
             Err(Error::new(Errno::EAGAIN))
         }
     }
 }
 
-    /// Updates pending ops after the val changed.
+/// Update pending const and alter operations, ref: <https://elixir.bootlin.com/linux/v6.0.9/source/ipc/sem.c#L1029>
-    fn update_pending_ops(&self, mut val: SpinLockGuard<i32, PreemptDisabled>, current_pid: Pid) {
+pub(super) fn do_smart_update(
-        debug_assert!(*val >= 0);
+    inner: &mut SpinLockGuard<SemSetInner, PreemptDisabled>,
-        trace!("Updating pending ops, semaphore before: {:?}", *val);
+    pending_op: &PendingOp,
+) -> LinkedList<PendingOp> {
+    let mut wake_queue = LinkedList::new();
 
-        // Two steps:
+    let (sems, pending_alter, pending_const) = inner.field_mut();
-        // 1. Remove the pending_alters with `sem_op < 0` if it can.
-        // 2. If val is equal to 0, then clear pending_const
 
-        // Step one:
+    if !pending_const.is_empty() {
-        let mut value = *val;
+        do_smart_wakeup_zero(sems, pending_const, pending_op, &mut wake_queue);
-        let mut latest_modified_pid = current_pid;
-        if value > 0 {
-            let mut pending_alters = self.pending_alters.lock();
-            let mut cursor = pending_alters.cursor_front_mut();
-            while let Some(op) = cursor.current() {
-                if value == 0 {
-                    break;
     }
-                // Check if the process alive.
+    if !pending_alter.is_empty() {
-                if op.process.upgrade().is_none() {
+        update_pending_alter(sems, pending_alter, pending_const, &mut wake_queue);
-                    cursor.remove_current().unwrap();
-                    continue;
     }
 
-                debug_assert!(op.sem_buf.sem_op < 0);
+    wake_queue
+}
 
-                if op.sem_buf.sem_op.abs() as i32 <= value {
+/// Look for pending alter operations that can be completed, ref: <https://elixir.bootlin.com/linux/v6.0.9/source/ipc/sem.c#L949>
-                    trace!(
+pub(super) fn update_pending_alter(
-                        "Found removable pending op, op: {:?}, pid:{:?}",
+    sems: &mut Box<[Semaphore]>,
-                        op.sem_buf.sem_op,
+    pending_alter: &mut LinkedList<PendingOp>,
-                        op.pid
+    pending_const: &mut LinkedList<PendingOp>,
-                    );
+    wake_queue: &mut LinkedList<PendingOp>,
+) {
+    let mut cursor = pending_alter.cursor_front_mut();
+    while let Some(alter_op) = cursor.current() {
+        if let Ok(true) = perform_atomic_semop(sems, alter_op) {
+            let mut alter_op = cursor.remove_current_as_list().unwrap();
 
-                    value += i32::from(op.sem_buf.sem_op);
+            do_smart_wakeup_zero(sems, pending_const, alter_op.front().unwrap(), wake_queue);
-                    latest_modified_pid = op.pid;
+
-                    op.status.set_status(Status::Normal);
+            wake_queue.append(&mut alter_op);
-                    op.waker.wake_up();
-                    cursor.remove_current().unwrap();
         } else {
             cursor.move_next();
         }
     }
 }
 
-        if latest_modified_pid != 0 {
+/// Wakeup all wait for zero tasks, ref: <https://elixir.bootlin.com/linux/v6.0.9/source/ipc/sem.c#L893>
-            self.latest_modified_pid
+fn do_smart_wakeup_zero(
-                .store(latest_modified_pid, Ordering::Relaxed);
+    sems: &mut Box<[Semaphore]>,
-            self.update_otime();
+    pending_const: &mut LinkedList<PendingOp>,
+    pending_op: &PendingOp,
+    wake_queue: &mut LinkedList<PendingOp>,
+) {
+    for sop in pending_op.sops_iter() {
+        if sems.get(sop.sem_num as usize).unwrap().val == 0 {
+            wake_const_ops(sems, pending_const, wake_queue);
+            return;
         }
-
-        // Step two:
-        if value == 0 {
-            let mut pending_const = self.pending_const.lock();
-            pending_const.iter().for_each(|op| {
-                op.status.set_status(Status::Normal);
-                if op.process.upgrade().is_some() {
-                    trace!("Found removable pending op, op: 0, pid:{:?}", op.pid);
-                    op.waker.wake_up();
-                }
-            });
-            pending_const.clear();
-        }
-        *val = value;
-        trace!("Updated pending ops, semaphore after: {:?}", value);
     }
 }
 
-pub fn sem_op(
+/// Wakeup pending const operations, ref: <https://elixir.bootlin.com/linux/v6.0.9/source/ipc/sem.c#L854>
-    sem_id: key_t,
+pub(super) fn wake_const_ops(
-    sem_buf: &SemBuf,
+    sems: &mut Box<[Semaphore]>,
-    timeout: Option<Duration>,
+    pending_const: &mut LinkedList<PendingOp>,
-    ctx: &Context,
+    wake_queue: &mut LinkedList<PendingOp>,
-) -> Result<()> {
+) {
-    debug_assert!(sem_id > 0);
+    let mut cursor = pending_const.cursor_front_mut();
-    debug!("[semop] sembuf: {:?}", sem_buf);
+    while let Some(const_op) = cursor.current() {
-
+        if let Ok(true) = perform_atomic_semop(sems, const_op) {
-    let sem = {
+            wake_queue.append(&mut cursor.remove_current_as_list().unwrap());
-        let sem_sets = sem_sets();
+        } else {
-        let sem_set = sem_sets.get(&sem_id).ok_or(Error::new(Errno::EINVAL))?;
+            cursor.move_next();
-        // TODO: Support permission check
+        }
-        warn!("Semaphore operation doesn't support permission check now");
+    }
-
+}
-        sem_set
+
-            .get(sem_buf.sem_num as usize)
+/// Iter the sops and return the flags (alter, dupsop)
-            .ok_or(Error::new(Errno::EFBIG))?
+fn get_sops_flags(pending_op: &PendingOp) -> (bool, bool) {
-            .clone()
+    let mut alter = false;
-    };
+    let mut dupsop = false;
-
+    let mut dup = 0;
-    sem.sem_op(sem_buf, timeout, ctx)
+    for sop in pending_op.sops_iter() {
+        let mask: u64 = 1 << ((sop.sem_num) % 64);
+
+        if (dup & mask) != 0 {
+            dupsop = true;
+        }
+
+        if sop.sem_op != 0 {
+            alter = true;
+            dup |= mask;
+        }
+    }
+    (alter, dupsop)
+}
+
+/// Perform atomic semop, ref: <https://elixir.bootlin.com/linux/v6.0.9/source/ipc/sem.c#L719>
+/// 1. Return Ok(true) if the operation success.
+/// 2. Return Ok(false) if the caller needs to wait.
+/// 3. Return Err(err) if the operation cause error.
+fn perform_atomic_semop(sems: &mut Box<[Semaphore]>, pending_op: &mut PendingOp) -> Result<bool> {
+    let mut result;
+    for op in pending_op.sops_iter() {
+        let sem = sems.get(op.sem_num as usize).ok_or(Errno::EFBIG)?;
+        let flags = IpcFlags::from_bits_truncate(op.sem_flags as u32);
+        result = sem.val();
+
+        // Zero condition
+        if op.sem_op == 0 && result != 0 {
+            if flags.contains(IpcFlags::IPC_NOWAIT) {
+                return_errno!(Errno::EAGAIN);
+            } else {
+                return Ok(false);
+            }
+        }
+
+        result += i32::from(op.sem_op);
+        if result < 0 {
+            if flags.contains(IpcFlags::IPC_NOWAIT) {
+                return_errno!(Errno::EAGAIN);
+            } else {
+                return Ok(false);
+            }
+        }
+
+        if result > SEMVMX {
+            return_errno!(Errno::ERANGE);
+        }
+        if flags.contains(IpcFlags::SEM_UNDO) {
+            todo!()
+        }
+    }
+
+    // Success, do operation
+    for op in pending_op.sops_iter() {
+        let sem = &mut sems[op.sem_num as usize];
+        if op.sem_op != 0 {
+            sem.val += i32::from(op.sem_op);
+            sem.latest_modified_pid = pending_op.pid;
+        }
+    }
+
+    Ok(true)
 }

kernel/src/ipc/semaphore/system_v/sem_set.rs

@@ -8,14 +8,17 @@ use core::{
 
 use aster_rights::ReadOp;
 use id_alloc::IdAlloc;
-use ostd::sync::{Mutex, RwMutex, RwMutexReadGuard, RwMutexWriteGuard};
+use ostd::sync::{PreemptDisabled, RwLockReadGuard, RwLockWriteGuard};
 use spin::Once;
 
-use super::PermissionMode;
+use super::{
+    sem::{update_pending_alter, wake_const_ops, PendingOp, Status},
+    PermissionMode,
+};
 use crate::{
     ipc::{key_t, semaphore::system_v::sem::Semaphore, IpcPermission},
     prelude::*,
-    process::Credentials,
+    process::{Credentials, Pid},
     time::clocks::RealTimeCoarseClock,
 };
 
@@ -38,21 +41,110 @@ pub const SEMAEM: i32 = SEMVMX;
 pub struct SemaphoreSet {
     /// Number of semaphores in the set
     nsems: usize,
-    /// Semaphores
+    /// Inner
-    sems: Box<[Arc<Semaphore>]>,
+    inner: SpinLock<SemSetInner>,
     /// Semaphore permission
     permission: IpcPermission,
     /// Creation time or last modification via `semctl`
     sem_ctime: AtomicU64,
+    /// Last semop time.
+    sem_otime: AtomicU64,
+}
+
+#[derive(Debug)]
+pub(super) struct SemSetInner {
+    /// Semaphores
+    pub(super) sems: Box<[Semaphore]>,
+    /// Pending alter operations.
+    pub(super) pending_alter: LinkedList<PendingOp>,
+    /// Pending zeros operations.
+    pub(super) pending_const: LinkedList<PendingOp>,
+}
+
+impl SemSetInner {
+    pub fn field_mut(
+        &mut self,
+    ) -> (
+        &mut Box<[Semaphore]>,
+        &mut LinkedList<PendingOp>,
+        &mut LinkedList<PendingOp>,
+    ) {
+        (
+            &mut self.sems,
+            &mut self.pending_alter,
+            &mut self.pending_const,
+        )
+    }
 }
 
 impl SemaphoreSet {
+    pub fn pending_const_count(&self, sem_num: u16) -> usize {
+        let inner = self.inner.lock();
+        let pending_const = &inner.pending_const;
+        let mut count = 1;
+        for i in pending_const.iter() {
+            for sem_buf in i.sops_iter() {
+                if sem_buf.sem_num() == sem_num {
+                    count += 1;
+                }
+            }
+        }
+        count
+    }
+
+    pub fn pending_alter_count(&self, sem_num: u16) -> usize {
+        let inner = self.inner.lock();
+        let pending_alter = &inner.pending_alter;
+        let mut count = 1;
+        for i in pending_alter.iter() {
+            for sem_buf in i.sops_iter() {
+                if sem_buf.sem_num() == sem_num {
+                    count += 1;
+                }
+            }
+        }
+        count
+    }
+
     pub fn nsems(&self) -> usize {
         self.nsems
     }
 
-    pub fn get(&self, index: usize) -> Option<&Arc<Semaphore>> {
+    pub fn setval(&self, sem_num: usize, val: i32, pid: Pid) -> Result<()> {
-        self.sems.get(index)
+        if !(0..SEMVMX).contains(&val) {
+            return_errno!(Errno::ERANGE);
+        }
+
+        let mut inner = self.inner();
+        let (sems, pending_alter, pending_const) = inner.field_mut();
+        let sem = sems.get_mut(sem_num).ok_or(Error::new(Errno::EINVAL))?;
+
+        sem.set_val(val);
+        sem.set_latest_modified_pid(pid);
+
+        let mut wake_queue = LinkedList::new();
+        if val == 0 {
+            wake_const_ops(sems, pending_const, &mut wake_queue);
+        } else {
+            update_pending_alter(sems, pending_alter, pending_const, &mut wake_queue);
+        }
+
+        for wake_op in wake_queue {
+            wake_op.set_status(Status::Normal);
+            if let Some(waker) = wake_op.waker() {
+                waker.wake_up();
+            }
+        }
+
+        self.update_ctime();
+        Ok(())
+    }
+
+    pub fn get<T>(&self, sem_num: usize, func: &dyn Fn(&Semaphore) -> T) -> Result<T> {
+        let inner = self.inner();
+        Ok(func(
+            inner.sems.get(sem_num).ok_or(Error::new(Errno::EINVAL))?,
+        ))
     }
 
     pub fn permission(&self) -> &IpcPermission {
@@ -70,12 +162,23 @@ impl SemaphoreSet {
         );
     }
 
+    pub fn update_otime(&self) {
+        self.sem_otime.store(
+            RealTimeCoarseClock::get().read_time().as_secs(),
+            Ordering::Relaxed,
+        );
+    }
+
+    pub(super) fn inner(&self) -> SpinLockGuard<SemSetInner, PreemptDisabled> {
+        self.inner.lock()
+    }
+
     fn new(key: key_t, nsems: usize, mode: u16, credentials: Credentials<ReadOp>) -> Result<Self> {
         debug_assert!(nsems <= SEMMSL);
 
         let mut sems = Vec::with_capacity(nsems);
         for _ in 0..nsems {
-            sems.push(Arc::new(Semaphore::new(0)));
+            sems.push(Semaphore::new(0));
         }
 
         let permission =
@@ -83,18 +186,38 @@ impl SemaphoreSet {
 
         Ok(Self {
             nsems,
-            sems: sems.into_boxed_slice(),
             permission,
             sem_ctime: AtomicU64::new(RealTimeCoarseClock::get().read_time().as_secs()),
+            sem_otime: AtomicU64::new(0),
+            inner: SpinLock::new(SemSetInner {
+                sems: sems.into_boxed_slice(),
+                pending_alter: LinkedList::new(),
+                pending_const: LinkedList::new(),
+            }),
         })
     }
 }
 
 impl Drop for SemaphoreSet {
     fn drop(&mut self) {
-        for sem in self.sems.iter() {
+        let mut inner = self.inner();
-            sem.removed();
+        let pending_alter = &mut inner.pending_alter;
+        for pending_alter in pending_alter.iter_mut() {
+            pending_alter.set_status(Status::Removed);
+            if let Some(ref waker) = pending_alter.waker() {
+                waker.wake_up();
             }
+        }
+        pending_alter.clear();
+
+        let pending_const = &mut inner.pending_const;
+        for pending_const in pending_const.iter_mut() {
+            pending_const.set_status(Status::Removed);
+            if let Some(ref waker) = pending_const.waker() {
+                waker.wake_up();
+            }
+        }
+        pending_const.clear();
 
         ID_ALLOCATOR
             .get()
@@ -164,18 +287,18 @@ pub fn create_sem_set(nsems: usize, mode: u16, credentials: Credentials<ReadOp>)
     Ok(id)
 }
 
-pub fn sem_sets<'a>() -> RwMutexReadGuard<'a, BTreeMap<key_t, SemaphoreSet>> {
+pub fn sem_sets<'a>() -> RwLockReadGuard<'a, BTreeMap<key_t, SemaphoreSet>> {
     SEMAPHORE_SETS.read()
 }
 
-pub fn sem_sets_mut<'a>() -> RwMutexWriteGuard<'a, BTreeMap<key_t, SemaphoreSet>> {
+pub fn sem_sets_mut<'a>() -> RwLockWriteGuard<'a, BTreeMap<key_t, SemaphoreSet>> {
     SEMAPHORE_SETS.write()
 }
 
-static ID_ALLOCATOR: Once<Mutex<IdAlloc>> = Once::new();
+static ID_ALLOCATOR: Once<SpinLock<IdAlloc>> = Once::new();
 
 /// Semaphore sets in system
-static SEMAPHORE_SETS: RwMutex<BTreeMap<key_t, SemaphoreSet>> = RwMutex::new(BTreeMap::new());
+static SEMAPHORE_SETS: RwLock<BTreeMap<key_t, SemaphoreSet>> = RwLock::new(BTreeMap::new());
 
 pub(super) fn init() {
     ID_ALLOCATOR.call_once(|| {
@@ -183,6 +306,6 @@ pub(super) fn init() {
         // Remove the first index 0
         id_alloc.alloc();
 
-        Mutex::new(id_alloc)
+        SpinLock::new(id_alloc)
     });
 }

kernel/src/syscall/semctl.rs

@@ -4,6 +4,7 @@ use super::SyscallReturn;
 use crate::{
     ipc::{
         semaphore::system_v::{
+            sem::Semaphore,
             sem_set::{check_sem, sem_sets, sem_sets_mut, SemaphoreSet},
             PermissionMode,
         },
@@ -54,52 +55,39 @@ pub fn sys_semctl(
             }
 
             check_and_ctl(semid, PermissionMode::ALTER, |sem_set| {
-                let sem = sem_set
+                sem_set.setval(semnum as usize, val, ctx.process.pid())
-                    .get(semnum as usize)
-                    .ok_or(Error::new(Errno::EINVAL))?;
-
-                sem.set_val(val, ctx.process.pid())?;
-                sem_set.update_ctime();
-
-                Ok(())
             })?;
         }
         IpcControlCmd::SEM_GETVAL => {
+            fn sem_val(sem: &Semaphore) -> i32 {
+                sem.val()
+            }
             let val: i32 = check_and_ctl(semid, PermissionMode::READ, |sem_set| {
-                Ok(sem_set
+                sem_set.get(semnum as usize, &sem_val)
-                    .get(semnum as usize)
-                    .ok_or(Error::new(Errno::EINVAL))?
-                    .val())
             })?;
 
             return Ok(SyscallReturn::Return(val as isize));
         }
         IpcControlCmd::SEM_GETPID => {
+            fn sem_pid(sem: &Semaphore) -> Pid {
+                sem.latest_modified_pid()
+            }
             let pid: Pid = check_and_ctl(semid, PermissionMode::READ, |sem_set| {
-                Ok(sem_set
+                sem_set.get(semnum as usize, &sem_pid)
-                    .get(semnum as usize)
-                    .ok_or(Error::new(Errno::EINVAL))?
-                    .last_modified_pid())
             })?;
 
             return Ok(SyscallReturn::Return(pid as isize));
         }
         IpcControlCmd::SEM_GETZCNT => {
             let cnt: usize = check_and_ctl(semid, PermissionMode::READ, |sem_set| {
-                Ok(sem_set
+                Ok(sem_set.pending_const_count(semnum as u16))
-                    .get(semnum as usize)
-                    .ok_or(Error::new(Errno::EINVAL))?
-                    .pending_zero_count())
             })?;
 
             return Ok(SyscallReturn::Return(cnt as isize));
         }
         IpcControlCmd::SEM_GETNCNT => {
             let cnt: usize = check_and_ctl(semid, PermissionMode::READ, |sem_set| {
-                Ok(sem_set
+                Ok(sem_set.pending_alter_count(semnum as u16))
-                    .get(semnum as usize)
-                    .ok_or(Error::new(Errno::EINVAL))?
-                    .pending_alter_count())
             })?;
 
             return Ok(SyscallReturn::Return(cnt as isize));

kernel/src/syscall/semop.rs

@@ -58,10 +58,12 @@ fn do_sys_semtimedop(
     }
 
     let user_space = ctx.get_user_space();
+    let mut semops = Vec::with_capacity(nsops);
     for i in 0..nsops {
-        let sem_buf = user_space.read_val::<SemBuf>(tsops + size_of::<SemBuf>() * i)?;
+        semops.push(user_space.read_val::<SemBuf>(tsops + size_of::<SemBuf>() * i)?);
-        sem_op(sem_id, &sem_buf, timeout, ctx)?;
     }
 
+    sem_op(sem_id, semops, timeout, ctx)?;
+
     Ok(SyscallReturn::Return(0))
 }