Samuka007/asterinas
1
0
Fork 0
mirror of https://github.com/asterinas/asterinas.git synced 2025-06-08 12:56:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tweak RCU visiblity and safety

Browse Source
This commit is contained in:
Ruihan Li 2025-05-07 23:54:11 +08:00 committed by Junyang Zhang
parent 2b00fe9e45
commit 899a1424c0
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ostd/src/sync/rcu/monitor.rs
View File

@ -15,7 +15,7 @@ use crate::{
/// A RCU monitor ensures the completion of _grace periods_ by keeping track /// A RCU monitor ensures the completion of _grace periods_ by keeping track
/// of each CPU's passing _quiescent states_. /// of each CPU's passing _quiescent states_.
pub struct RcuMonitor { pub(super) struct RcuMonitor {
is_monitoring: AtomicBool, is_monitoring: AtomicBool,
state: SpinLock<State>, state: SpinLock<State>,
} }
@ -25,7 +25,7 @@ impl RcuMonitor {
/// ///
/// This function is used to initialize a singleton instance of `RcuMonitor`. /// This function is used to initialize a singleton instance of `RcuMonitor`.
/// The singleton instance is globally accessible via the `RCU_MONITOR`. /// The singleton instance is globally accessible via the `RCU_MONITOR`.
pub fn new() -> Self { pub(super) fn new() -> Self {
Self { Self {
is_monitoring: AtomicBool::new(false), is_monitoring: AtomicBool::new(false),
state: SpinLock::new(State::new()), state: SpinLock::new(State::new()),
@ -73,7 +73,7 @@ impl RcuMonitor {
} }
} }
pub fn after_grace_period<F>(&self, f: F) pub(super) fn after_grace_period<F>(&self, f: F)
where where
F: FnOnce() + Send + 'static, F: FnOnce() + Send + 'static,
{ {
@ -97,7 +97,7 @@ struct State {
} }
impl State { impl State {
pub fn new() -> Self { fn new() -> Self {
Self { Self {
current_gp: GracePeriod::new(), current_gp: GracePeriod::new(),
next_callbacks: VecDeque::new(), next_callbacks: VecDeque::new(),
@ -114,7 +114,7 @@ struct GracePeriod {
} }
impl GracePeriod { impl GracePeriod {
pub fn new() -> Self { fn new() -> Self {
Self { Self {
callbacks: Callbacks::new(), callbacks: Callbacks::new(),
cpu_mask: AtomicCpuSet::new(CpuSet::new_empty()), cpu_mask: AtomicCpuSet::new(CpuSet::new_empty()),
@ -122,11 +122,11 @@ impl GracePeriod {
} }
} }
pub fn is_complete(&self) -> bool { fn is_complete(&self) -> bool {
self.is_complete self.is_complete
} }
unsafe fn finish_grace_period(&mut self, this_cpu: CpuId) { fn finish_grace_period(&mut self, this_cpu: CpuId) {
self.cpu_mask.add(this_cpu, Ordering::Relaxed); self.cpu_mask.add(this_cpu, Ordering::Relaxed);
if self.cpu_mask.load(Ordering::Relaxed).is_full() { if self.cpu_mask.load(Ordering::Relaxed).is_full() {
@ -134,11 +134,11 @@ impl GracePeriod {
} }
} }
pub fn take_callbacks(&mut self) -> Callbacks { fn take_callbacks(&mut self) -> Callbacks {
core::mem::take(&mut self.callbacks) core::mem::take(&mut self.callbacks)
} }
pub fn restart(&mut self, callbacks: Callbacks) { fn restart(&mut self, callbacks: Callbacks) {
self.is_complete = false; self.is_complete = false;
self.cpu_mask.store(&CpuSet::new_empty(), Ordering::Relaxed); self.cpu_mask.store(&CpuSet::new_empty(), Ordering::Relaxed);
self.callbacks = callbacks; self.callbacks = callbacks;