Improve readability

This commit is contained in:
Marsman1996
2024-08-21 23:02:16 +08:00
committed by Tate, Hongliang Tian
parent 95aaef9aa1
commit 90688286aa

View File

@ -188,25 +188,25 @@ impl PosixTimerManager {
/// Finds a POSIX timer by the input `timer_id`. /// Finds a POSIX timer by the input `timer_id`.
pub fn find_posix_timer(&self, timer_id: usize) -> Option<Arc<Timer>> { pub fn find_posix_timer(&self, timer_id: usize) -> Option<Arc<Timer>> {
let timers = self.posix_timers.lock(); let timers = self.posix_timers.lock();
if timer_id < timers.len() { if timer_id >= timers.len() {
timers[timer_id].clone() return None;
} else {
None
} }
timers[timer_id].clone()
} }
/// Removes the POSIX timer with the ID `timer_id`. /// Removes the POSIX timer with the ID `timer_id`.
pub fn remove_posix_timer(&self, timer_id: usize) -> Option<Arc<Timer>> { pub fn remove_posix_timer(&self, timer_id: usize) -> Option<Arc<Timer>> {
let mut timers = self.posix_timers.lock(); let mut timers = self.posix_timers.lock();
if timer_id < timers.len() { if timer_id >= timers.len() {
let timer = timers[timer_id].take(); return None;
if timer.is_some() {
// Holding the lock of `posix_timers` is required to operate the `id_allocator`.
self.id_allocator.lock().free(timer_id);
}
timer
} else {
None
} }
let timer = timers[timer_id].take();
if timer.is_some() {
// Holding the lock of `posix_timers` is required to operate the `id_allocator`.
self.id_allocator.lock().free(timer_id);
}
timer
} }
} }