From 9505e5704e7203735bdda5fd2ea04ebf0df64e5b Mon Sep 17 00:00:00 2001 From: Ruihan Li Date: Sun, 30 Jun 2024 23:10:07 +0800 Subject: [PATCH] Avoid the unused `rights` field --- kernel/aster-nix/src/fs/utils/channel.rs | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/kernel/aster-nix/src/fs/utils/channel.rs b/kernel/aster-nix/src/fs/utils/channel.rs index 024ea0cc..f3c2e992 100644 --- a/kernel/aster-nix/src/fs/utils/channel.rs +++ b/kernel/aster-nix/src/fs/utils/channel.rs @@ -1,7 +1,5 @@ // SPDX-License-Identifier: MPL-2.0 -#![allow(dead_code)] - use core::sync::atomic::{AtomicBool, AtomicU32, Ordering}; use aster_rights::{Read, ReadOp, TRights, Write, WriteOp}; @@ -29,8 +27,8 @@ impl Channel { pub fn with_capacity_and_flags(capacity: usize, flags: StatusFlags) -> Result { let common = Arc::new(Common::with_capacity_and_flags(capacity, flags)?); - let producer = Producer(EndPoint::new(common.clone(), WriteOp::new())); - let consumer = Consumer(EndPoint::new(common, ReadOp::new())); + let producer = Producer(EndPoint::new(common.clone())); + let consumer = Consumer(EndPoint::new(common)); Ok(Self { producer, consumer }) } @@ -387,12 +385,15 @@ impl Drop for Consumer { struct EndPoint { common: Arc>, - rights: R, + _rights: R, } impl EndPoint { - pub fn new(common: Arc>, rights: R) -> Self { - Self { common, rights } + pub fn new(common: Arc>) -> Self { + Self { + common, + _rights: R::new(), + } } }