Samuka007/asterinas
1
0
Fork 0
mirror of https://github.com/asterinas/asterinas.git synced 2025-06-20 13:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor and test get{pgid,sid}

Browse Source
This commit is contained in:
Ruihan Li
2025-05-02 22:43:16 +08:00
committed by Jianfeng Jiang
parent 7e4509df9c
commit a993264265
4 changed files with 97 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
kernel/src/syscall/getpgid.rs
View File

@ -8,25 +8,24 @@ use crate::{
pub fn sys_getpgid(pid: Pid, ctx: &Context) -> Result<SyscallReturn> {
debug!("pid = {}", pid);
// type Pid = u32, pid would never less than 0.
// if pid < 0 {
// return_errno_with_message!(Errno::EINVAL, "pid cannot be negative");
// }
// if pid is 0, should return the pgid of current process
// The documentation quoted below is from
// <https://www.man7.org/linux/man-pages/man2/getpgid.2.html>.
// "If `pid` is equal to 0, getpgid() shall return the process group ID of the calling
// process."
if pid == 0 {
return Ok(SyscallReturn::Return(ctx.process.pgid() as _));
}
let process = process_table::get_process(pid)
.ok_or(Error::with_message(Errno::ESRCH, "process does not exist"))?;
let process = process_table::get_process(pid).ok_or(Error::with_message(
Errno::ESRCH,
"the process to get the PGID does not exist",
))?;
if !Arc::ptr_eq(&ctx.process.session().unwrap(), &process.session().unwrap()) {
return_errno_with_message!(
Errno::EPERM,
"the process and current process does not belong to the same session"
);
}
// The man pages allow the implementation to return `EPERM` if `process` is in a different
// session than the current process. Linux does not perform this check by default, but some
// strict security policies (e.g. SELinux) may do so.
Ok(SyscallReturn::Return(process.pgid() as _))
}

25
kernel/src/syscall/getsid.rs
View File

@ -9,23 +9,22 @@ use crate::{
pub fn sys_getsid(pid: Pid, ctx: &Context) -> Result<SyscallReturn> {
debug!("pid = {}", pid);
let session = ctx.process.session().unwrap();
let sid = session.sid();
// The documentation quoted below is from
// <https://www.man7.org/linux/man-pages/man2/getsid.2.html>.
// "If `pid` is 0, getsid() returns the session ID of the calling process."
if pid == 0 {
return Ok(SyscallReturn::Return(sid as _));
return Ok(SyscallReturn::Return(ctx.process.sid() as _));
}
let Some(process) = process_table::get_process(pid) else {
return_errno_with_message!(Errno::ESRCH, "the process does not exist")
};
let process = process_table::get_process(pid).ok_or(Error::with_message(
Errno::ESRCH,
"the process to get the SID does not exist",
))?;
if !Arc::ptr_eq(&session, &process.session().unwrap()) {
return_errno_with_message!(
Errno::EPERM,
"the process and current process does not belong to the same session"
);
}
// The man pages allow the implementation to return `EPERM` if `process` is in a different
// session than the current process. Linux does not perform this check by default, but some
// strict security policies (e.g. SELinux) may do so.
Ok(SyscallReturn::Return(sid as _))
Ok(SyscallReturn::Return(process.sid() as _))
}