faas-rs/faas
1
0
Fork 0
mirror of https://github.com/openfaas/faas.git synced 2025-06-18 12:06:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adjusted code accordingly to feedback

Browse Source 
Based on the received feedback I updated the documentation of the function. Also replaced variable temp by an more declaritive variable.
Signed-off-by: Simon Pelczer <templum.dev@gmail.com>
This commit is contained in:
Templum
2018-04-03 19:27:47 +02:00
committed by Alex Ellis
parent 6cd6975fe5
commit 0b28e96a58
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gateway/plugin/external.go
View File

@ -95,12 +95,12 @@ func (s ExternalServiceQuery) GetReplicas(serviceName string) (handlers.ServiceQ
minReplicas = extractLabelValue(labels[handlers.MinScaleLabel], minReplicas) minReplicas = extractLabelValue(labels[handlers.MinScaleLabel], minReplicas)
maxReplicas = extractLabelValue(labels[handlers.MaxScaleLabel], maxReplicas) maxReplicas = extractLabelValue(labels[handlers.MaxScaleLabel], maxReplicas)
temp := extractLabelValue(labels[handlers.ScalingFactorLabel], scalingFactor) extractedScalingFactor := extractLabelValue(labels[handlers.ScalingFactorLabel], scalingFactor)
if temp >= 0 && temp <= 100 { if extractedScalingFactor >= 0 && extractedScalingFactor <= 100 {
scalingFactor = temp scalingFactor = extractedScalingFactor
} else { } else {
log.Printf("Bad Scaling Factor: %d, is in range [0 - 100]", temp) log.Printf("Bad Scaling Factor: %d, is not in range of [0 - 100]. Will fallback to %d", extractedScalingFactor, scalingFactor)
} }
} }
@ -147,8 +147,8 @@ func (s ExternalServiceQuery) SetReplicas(serviceName string, count uint64) erro
return err return err
} }
// This methods tries to parse the provided raw label value and if it fails // extractLabelValue will parse the provided raw label value and if it fails
// it will return the provided fallback value and log and message // it will return the provided fallback value and log an message
func extractLabelValue(rawLabelValue string, fallback uint64 ) uint64{ func extractLabelValue(rawLabelValue string, fallback uint64 ) uint64{
if len(rawLabelValue) <= 0 { if len(rawLabelValue) <= 0 {
return fallback return fallback