faas-rs/faas
1
0
Fork 0
mirror of https://github.com/openfaas/faas.git synced 2025-06-12 18:26:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove service namespace from scale request

Browse Source 
This field doesn't appear to be used and is supplied via the
querystring which faas-netes (the only ns-enabled provider
already consumes)

Related to PR:

https://github.com/openfaas/faas-netes/pull/671

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
This commit is contained in:
Alex Ellis (OpenFaaS Ltd) 2020-07-20 10:05:37 +01:00 committed by Alex Ellis
parent 3e46a62ce2
commit 11ff356cce
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gateway/plugin/external.go
View File

@ -27,13 +27,6 @@ type ExternalServiceQuery struct {
AuthInjector middleware.AuthInjector AuthInjector middleware.AuthInjector
} }
// ScaleServiceRequest request scaling of replica
type ScaleServiceRequest struct {
ServiceName string `json:"serviceName"`
ServiceNamespace string `json:"serviceNamespace"`
Replicas uint64 `json:"replicas"`
}
// NewExternalServiceQuery proxies service queries to external plugin via HTTP // NewExternalServiceQuery proxies service queries to external plugin via HTTP
func NewExternalServiceQuery(externalURL url.URL, authInjector middleware.AuthInjector) scaling.ServiceQuery { func NewExternalServiceQuery(externalURL url.URL, authInjector middleware.AuthInjector) scaling.ServiceQuery {
timeout := 3 * time.Second timeout := 3 * time.Second
@ -134,10 +127,9 @@ func (s ExternalServiceQuery) GetReplicas(serviceName, serviceNamespace string)
func (s ExternalServiceQuery) SetReplicas(serviceName, serviceNamespace string, count uint64) error { func (s ExternalServiceQuery) SetReplicas(serviceName, serviceNamespace string, count uint64) error {
var err error var err error
scaleReq := ScaleServiceRequest{ scaleReq := types.ScaleServiceRequest{
ServiceName: serviceName, ServiceName: serviceName,
Replicas: count, Replicas: count,
ServiceNamespace: serviceNamespace,
} }
requestBody, err := json.Marshal(scaleReq) requestBody, err := json.Marshal(scaleReq)