Enable hashed passwords with PowerShell

- PR #929 introduced the ability to generate passwords for the
gateway admin user, this is a good step forwards for Windows
users. It did introduce an inconsistency in the format that
passwords are stored by not using a form of hashing. Hashing
of secrets is used extensively within OpenFaaS/OpenFaaS Cloud
whether with Swarm or Kubernetes via helm. If there are
concerns about using a hashed value for a password I would
suggest raising an issue to track this and have any decision
we make applied for all users (not just PowerShell users).

As a  compromise I've introduced hashing by default and added
a new flag called -noHash which can be used to replicate the
behaviour of the original PR.

After feedback from other contributors I also looked into whether
the flag syntax could match the existing syntax but left this as
is. Bash will use --no-auth and PowerShell will use --noAuth.

This was tested on Docker Swarm on Windows.

Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
This commit is contained in:
Alex Ellis (VMware)
2018-11-04 20:37:11 +00:00
parent 47a834c830
commit 169431375d

View File

@ -2,6 +2,7 @@
param (
[switch] $noAuth,
[switch] $noHash,
[switch] $n,
[switch] $help,
[switch] $h
@ -11,6 +12,7 @@ if ($help -Or $h) {
Write-Host "Usage: "
Write-Host " [default]`tdeploy the OpenFaaS core services"
Write-Host " -noAuth [-n]`tdisable basic authentication"
Write-Host " -noHash`tprevents the password from being hashed (optional)"
Write-Host " -help [-h]`tdisplays this screen"
Exit
}
@ -23,8 +25,21 @@ if (Get-Command docker -errorAction SilentlyContinue)
throw "Docker not in swarm mode, please initialise the cluster (`docker swarm init`) and retry"
}
# AE: would be nice to avoid this dependency.
Add-Type -AssemblyName System.Web
$secret = [System.Web.Security.Membership]::GeneratePassword(24,5)
$password = [System.Web.Security.Membership]::GeneratePassword(24,5)
$secret = ""
if (-Not $noHash)
{
$sha256 = [System.Security.Cryptography.HashAlgorithm]::Create('sha256')
$hash = $sha256.ComputeHash([System.Text.Encoding]::UTF8.GetBytes($password))
$secret = [System.BitConverter]::ToString($hash).Replace('-', '').toLower()
} else {
$secret =$password
}
$user = 'admin'
Write-Host "Attempting to create credentials for gateway.."
@ -68,9 +83,10 @@ if (Get-Command docker -errorAction SilentlyContinue)
}
Write-Host "Deploying OpenFaaS core services"
docker stack deploy func --compose-file ./docker-compose.yml
docker stack deploy func --compose-file ./docker-compose.yml --orchestrator swarm
}
else
{
throw "Unable to find docker command, please install Docker (https://www.docker.com/) and retry"
}