From 4c12c2e2f8f3f4b4bfd740afee628d8b5524230c Mon Sep 17 00:00:00 2001 From: Lucas Roesler Date: Fri, 28 Jun 2019 19:57:38 +0200 Subject: [PATCH] Add tests for loading the logs provider value from the env **What** - Ensure that we are loading the log provider url correctly, including fallback to the function provider, when the value is set Signed-off-by: Lucas Roesler --- gateway/types/readconfig_test.go | 34 ++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/gateway/types/readconfig_test.go b/gateway/types/readconfig_test.go index 4a8ccdea..13b6ed92 100644 --- a/gateway/types/readconfig_test.go +++ b/gateway/types/readconfig_test.go @@ -341,3 +341,37 @@ func TestRead_AuthProxy_DefaultsOverrides(t *testing.T) { t.Fail() } } + +func TestRead_LogsProviderURL(t *testing.T) { + defaults := NewEnvBucket() + + t.Run("default value is nil when functions_provider_url is empty", func(t *testing.T) { + readConfig := ReadConfig{} + config := readConfig.Read(defaults) + if config.LogsProviderURL != nil { + t.Fatalf("config.LogsProviderURL, want: %s, got: %s\n", "", config.LogsProviderURL) + } + }) + + t.Run("default value is equal to functions_provider_url", func(t *testing.T) { + expected := "functions.example.com" + defaults.Setenv("functions_provider_url", expected) + + readConfig := ReadConfig{} + config := readConfig.Read(defaults) + if config.LogsProviderURL.String() != expected { + t.Fatalf("config.LogsProviderURL, want: %s, got: %s\n", expected, config.LogsProviderURL) + } + }) + + t.Run("override by logs_provider_url", func(t *testing.T) { + expected := "logs.example.com" + defaults.Setenv("logs_provider_url", expected) + + readConfig := ReadConfig{} + config := readConfig.Read(defaults) + if config.LogsProviderURL.String() != expected { + t.Fatalf("config.LogsProviderURL, want: %s, got: %s\n", expected, config.LogsProviderURL) + } + }) +}