From 59ca597903654afa577b24362f09ca6800369ee7 Mon Sep 17 00:00:00 2001 From: Alex Date: Mon, 23 Jan 2017 22:12:47 +0000 Subject: [PATCH] Fix if-guard for replica scaling --- gateway/server.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gateway/server.go b/gateway/server.go index 377f53ac..a1b96a16 100644 --- a/gateway/server.go +++ b/gateway/server.go @@ -23,7 +23,7 @@ func scaleService(req requests.PrometheusAlert, c *client.Client) error { //Todo: convert to loop / handler. serviceName := req.Alerts[0].Labels.FunctionName service, _, inspectErr := c.ServiceInspectWithRaw(context.Background(), serviceName) - if inspectErr != nil { + if inspectErr == nil { var replicas uint64 if req.Status == "firing" { @@ -60,12 +60,17 @@ func scaleService(req requests.PrometheusAlert, c *client.Client) error { func makeAlertHandler(c *client.Client) http.HandlerFunc { return func(w http.ResponseWriter, r *http.Request) { log.Println("Alert received.") - body, _ := ioutil.ReadAll(r.Body) + body, readErr := ioutil.ReadAll(r.Body) + if readErr != nil { + log.Println(readErr) + return + } var req requests.PrometheusAlert err := json.Unmarshal(body, &req) if err != nil { log.Println(err) + return } if len(req.Alerts) > 0 {