should use strings.Contains() instead of stings.Index()

Signed-off-by: wgliang <liangcszzu@163.com>
This commit is contained in:
wangguoliang 2017-09-07 18:16:41 +08:00 committed by Alex Ellis
parent 622b24268d
commit 94a15e44d5
2 changed files with 3 additions and 3 deletions

View File

@ -42,7 +42,7 @@ func MakeFunctionReader(metricsOptions metrics.MetricOptions, c *client.Client)
var envProcess string
for _, env := range service.Spec.TaskTemplate.ContainerSpec.Env {
if strings.Index(env, "fprocess=") > -1 {
if strings.Contains(env, "fprocess=") {
envProcess = env[len("fprocess="):]
}
}

View File

@ -47,7 +47,7 @@ func TestHandler_HasCustomHeaderInFunction_WithCgi_Mode(t *testing.T) {
read, _ := ioutil.ReadAll(rr.Body)
val := string(read)
if strings.Index(val, "Http_Custom_Header") == -1 {
if !strings.Contains(val, "Http_Custom_Header") {
t.Errorf("'env' should printed: Http_Custom_Header, got: %s\n", val)
}
@ -83,7 +83,7 @@ func TestHandler_DoesntHaveCustomHeaderInFunction_WithoutCgi_Mode(t *testing.T)
read, _ := ioutil.ReadAll(rr.Body)
val := string(read)
if strings.Index(val, "Http_Custom_Header") != -1 {
if strings.Contains(val, "Http_Custom_Header") {
t.Errorf("'env' should not have printed: Http_Custom_Header, got: %s\n", val)
}