From b4a6872c04b00d8acdc5765012bc243d360e5f2d Mon Sep 17 00:00:00 2001 From: Lars Lehtonen Date: Tue, 4 Feb 2020 10:55:41 -0800 Subject: [PATCH] gateway/handlers: fix use of testing.T inside goroutine Signed-off-by: Lars Lehtonen --- gateway/handlers/logs_test.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/gateway/handlers/logs_test.go b/gateway/handlers/logs_test.go index 9c0f0ffd..6f8a20d0 100644 --- a/gateway/handlers/logs_test.go +++ b/gateway/handlers/logs_test.go @@ -122,13 +122,17 @@ func Test_logsProxyDoesNotLeakGoroutinesWhenClientClosesConnection(t *testing.T) t.Fatalf("unexpected error sending log request: %s", err) } + errCh := make(chan error, 1) go func() { defer resp.Body.Close() + defer close(errCh) _, err := ioutil.ReadAll(resp.Body) - if err != context.Canceled { - t.Fatalf("unexpected error reading the response body: %s", err) - } + errCh <- err }() - cancel() + err = <-errCh + if err != context.Canceled { + t.Fatalf("unexpected error reading the response body: %s", err) + } + }