Update comments

- updates comments and adds where missing
- updates locks so that unlock is done via defer instead of
at the end of the statement
- extracts timeout variable in two places
- remove makeClient() unused method from metrics package

No-harm changes tested via go build.

Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
This commit is contained in:
Alex Ellis
2018-10-03 13:16:28 +01:00
parent 609ef28cad
commit bd39b9267a
9 changed files with 40 additions and 34 deletions

View File

@ -1,17 +1,20 @@
package version
var (
//Version release version of the provider
// Version release version of the provider
Version string
//GitCommit SHA of the last git commit
// GitCommitSHA is the Git SHA of the latest tag/release
GitCommitSHA string
//GitCommit message of the last commit
// GitCommitMessage as read from the latest tag/release
GitCommitMessage string
//DevVersion string for the development version
// DevVersion string for the development version
DevVersion = "dev"
)
//BuildVersion returns current version of the provider
// BuildVersion returns current version of the provider
func BuildVersion() string {
if len(Version) == 0 {
return DevVersion