faas-rs/faas
1
0
Fork 0
mirror of https://github.com/openfaas/faas.git synced 2025-06-23 15:23:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return error from upstream when calling list functions

Browse Source 
This is currently being hidden and needs to be bubbled up
into the logs to show an issue with calling list functions
during a deletion in faasd.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
This commit is contained in:
Alex Ellis (OpenFaaS Ltd)
2021-02-27 20:18:34 +00:00
parent 089cd332b8
commit f8576d5b5d
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gateway/metrics/add_metrics.go
View File

@ -28,15 +28,19 @@ func AddMetricsHandler(handler http.HandlerFunc, prometheusQuery PrometheusQuery
}
defer upstreamCall.Body.Close()
upstreamBody, _ := ioutil.ReadAll(upstreamCall.Body)
if recorder.Code != http.StatusOK {
log.Printf("List functions responded with code %d, body: %s",
recorder.Code,
string(upstreamBody))
w.Header().Set("Content-Type", "text/plain")
w.WriteHeader(http.StatusInternalServerError)
w.Write([]byte(fmt.Sprintf("Error pulling metrics from provider/backend. Status code: %d", recorder.Code)))
w.Write([]byte(fmt.Sprintf("List functions responded with code %d", recorder.Code)))
return
}
upstreamBody, _ := ioutil.ReadAll(upstreamCall.Body)
var functions []types.FunctionStatus
err := json.Unmarshal(upstreamBody, &functions)