- the shutdown sequence meant that the kubelet was still passing
work to the watchdog after the HTTP socket was closed. This change
means that the kubelet has a chance to run its check before we
finally stop accepting new connections. It will require some
basic co-ordination between the kubelet's checking period and the
"write_timeout" value in the container.
Tested with Kubernetes on GKE - before the change some Pods were
giving a connection refused error due to them being not detected
as unhealthy. Now I receive 0% error rate even with 20 qps.
Issue was shown by scaling to 20 replicas, starting a test with
hey and then scaling to 1 replica while tailing the logs from the
gateway. Before I saw some 502, now I see just 200s.
Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
This moves watchdog to a better name for images and also gives free
image-scanning and gives more confidence to users that components
ship regularly and makes any vulnerabilities in components clear
Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
This changes introduces a new flag -version to watchdog which will
display version and SHA of last git commit.
Version and SHA are injected at build time and passed as a
build-args for Dockerfile.
Fixes: #632
Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in>
Note, not all `alexellis/github` references should be changed, there are
a number of repos which are not part of the openfaas org, this commit
excludes those.
Signed-off-by: John McCabe <john@johnmccabe.net>
