The Content-Type header must be ignored when the Transfer
Encoding is set to "chunked" because the length is unknown
Go sets this to -1 and we pass that onto the user:
https://golang.org/src/net/http/transfer.go
The value of Content_Length is currently set to -1 in this
scenario, however it caused some confusion for at least one
user in issue: #1422.
The Http_Transfer_Encoding value was tested by running the
watchdog on Linux with "env" as the fprocess and an extra
header to "curl"
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
This flag is useful for some users that prefer a scratch image
that cannot execute a bash healthcheck. Instead they can execute
the watchdog itself such as:
"watchdog -run-healthcheck"
It will return a non-zero exit code for when the lock file is not
found.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
This enables limiting concurrency. It is a naive approach which
will reject requests as soon as they exceed the maximum number
of in-flight requests.
It is a port of the following PR from the new watchdog code:
https://github.com/openfaas-incubator/of-watchdog/pull/54
Signed-off-by: Sargun Dhillon <sargun@sargun.me>
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
- this PR adds metrics via Prometheus for instrumentation and
to move towards using HPAv2 / custom metrics in Kubernetes.
Signed-off-by: Alex Ellis <alexellis2@gmail.com>
We need to update the watchdog version for sample functions to 0.9.14
including all references in markdown files.
Signed-off-by: Ron Rivera <roncrivera@gmail.com>
- Removes use of "our" from CONTRIBUTING guide
- Updates/adds README.md files
- Commnents and typo fix in watchdog
- Adds good/bad examples of commit messages
Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
- the shutdown sequence meant that the kubelet was still passing
work to the watchdog after the HTTP socket was closed. This change
means that the kubelet has a chance to run its check before we
finally stop accepting new connections. It will require some
basic co-ordination between the kubelet's checking period and the
"write_timeout" value in the container.
Tested with Kubernetes on GKE - before the change some Pods were
giving a connection refused error due to them being not detected
as unhealthy. Now I receive 0% error rate even with 20 qps.
Issue was shown by scaling to 20 replicas, starting a test with
hey and then scaling to 1 replica while tailing the logs from the
gateway. Before I saw some 502, now I see just 200s.
Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
Convert all sample-functions to use curl to get the watchdog as
it can be cached by Docker. Issue #841
Signed-off-by: Radoslav Dimitrov <rdimitrow@gmail.com>
Full list of supported verbs is now supported: "GET", "POST", "PUT",
"PATCH", "DELETE"
Relates to: #openfaas/faas/issues/815
Signed-off-by: Edward Wilde <ewilde@gmail.com>
This test takes inspiration from the PR from @telackey with changes
to make it more maintainable. Since the test does not require
changes to the code, I wanted to add it before merging changes.
Ref: https://github.com/openfaas/faas/pull/789
Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
This moves watchdog to a better name for images and also gives free
image-scanning and gives more confidence to users that components
ship regularly and makes any vulnerabilities in components clear
Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
Issue #660 has been open for a while to update to 1.9.6, this
performs the update to the latest in the 1.9 release (1.9.7)
Signed-off-by: Sean Smith <sean@wwsean08.com>
Moves handler code into separate file but retains same
package.
Changes watchdog to print version on start-up so that we can
grab this from logs. Version flag is also present for getting
additional information if needed from a user's published
container without running their function.
Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
This changes introduces a new flag -version to watchdog which will
display version and SHA of last git commit.
Version and SHA are injected at build time and passed as a
build-args for Dockerfile.
Fixes: #632
Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in>
This updates fwatchdog to latest version (0.7.9) in all templates
in sample-functions and faas version in the documentation
Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
If the watchdog is sent SIGTERM from an external process then it
should stop accepting new connections and attempt to finish the
work in progress. This change makes use of the new ability in Go
1.9 and onwards to cancel a HTTP server gracefully.
The write_timeout duration is used as a grace period to allow all
in-flight requests to complete. The pattern is taken directly from
the offical example in the Golang documentation. [1]
Further tuning and testing may be needed for Windows containers which
have a different set of signals for closing work. This change aims
to cover the majority use-case for Linux containers.
The HTTP health-check is also invalidated by creating an and
expression with the existing lock file.
Tested with Kubernetes by deploying a custom watchdog and the
fprocess of `env`. Log message was observed when scaling down and
connections stopped being accepted on terminating replica.
Also corrects some typos from previous PR.
[1] https://golang.org/pkg/net/http/#Server.Shutdown
Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
This commit replaces occurences of http method strings with the
corresponding consts from the http package.
*Note* UPDATE is not strictly speaking a valid method and as such isn't
part of the http package (should be a PUT or PATCH?)
Signed-off-by: John McCabe <john@johnmccabe.net>
The default should be set to true so we maintain backwards.
compatibility.
readconfig.go was altered due to bug reading default value. This was
tested by adding unit tests to readconfig_test.go for positive and
negative scenarios.
Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
Introduce new endpoint `/_/health` to watchdog for health status of
functions which check for `/tmp/.lock` file
Fixes first part of #547 issue.
Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in>
Integration test for combine_output should use stat instead of
man as man is not installed in the CI system.
Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
This enables an often-requested feature to separate stderr
from stdout within function responses. New flag combine_output is on
by default to match existing behaviour. When combine_output is set
to false it redirects stderr to the container logs rather than
combining it into the function response.
Tested with unit tests for default behaviour and new behaviour.
Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
