mirror of
https://github.com/openfaas/faas.git
synced 2025-06-10 17:26:47 +00:00
An explicit timeout is passed to the handler and a new unit test proves that the functionality is in place. A additional return statement was needed in the handler as pointed out by @stefanprodan. Signed-off-by: Alex Ellis <alexellis2@gmail.com>
80 lines
2.0 KiB
Go
80 lines
2.0 KiB
Go
package handlers
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func Test_External_Auth_Wrapper_FailsInvalidAuth(t *testing.T) {
|
|
|
|
s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusForbidden)
|
|
}))
|
|
defer s.Close()
|
|
|
|
next := func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusNotImplemented)
|
|
}
|
|
|
|
passBody := false
|
|
handler := MakeExternalAuthHandler(next, time.Second*5, s.URL, passBody)
|
|
|
|
req := httptest.NewRequest(http.MethodGet, s.URL, nil)
|
|
rr := httptest.NewRecorder()
|
|
handler(rr, req)
|
|
|
|
if rr.Code == http.StatusOK {
|
|
t.Errorf("Status incorrect, did not want: %d, but got %d", http.StatusOK, rr.Code)
|
|
}
|
|
}
|
|
|
|
func Test_External_Auth_Wrapper_PassesValidAuth(t *testing.T) {
|
|
|
|
s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusOK)
|
|
}))
|
|
defer s.Close()
|
|
|
|
next := func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusNotImplemented)
|
|
}
|
|
|
|
passBody := false
|
|
handler := MakeExternalAuthHandler(next, time.Second*5, s.URL, passBody)
|
|
|
|
req := httptest.NewRequest(http.MethodGet, s.URL, nil)
|
|
rr := httptest.NewRecorder()
|
|
handler(rr, req)
|
|
want := http.StatusNotImplemented
|
|
if rr.Code != want {
|
|
t.Errorf("Status incorrect, want: %d, but got %d", want, rr.Code)
|
|
}
|
|
}
|
|
|
|
func Test_External_Auth_Wrapper_TimeoutGivesInternalServerError(t *testing.T) {
|
|
|
|
s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
time.Sleep(50 * time.Millisecond)
|
|
w.WriteHeader(http.StatusOK)
|
|
}))
|
|
defer s.Close()
|
|
|
|
next := func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusNotImplemented)
|
|
}
|
|
|
|
passBody := false
|
|
handler := MakeExternalAuthHandler(next, time.Millisecond*10, s.URL, passBody)
|
|
|
|
req := httptest.NewRequest(http.MethodGet, s.URL, nil)
|
|
rr := httptest.NewRecorder()
|
|
handler(rr, req)
|
|
|
|
want := http.StatusInternalServerError
|
|
if rr.Code != want {
|
|
t.Errorf("Status incorrect, want: %d, but got %d", want, rr.Code)
|
|
}
|
|
}
|