faas/gateway/scaling/function_query.go
Alex Ellis (OpenFaaS Ltd) 6ed0ab71fb Move to single-flight for back-end queries
When querying for replicas during a scale up event, then the
gateway can overwhelm the provider with requests. This is
especially true under high concurrent load.

The changes in this PR limit the inflight requests.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alex@openfaas.com>
2022-06-29 09:43:58 +01:00

78 lines
2.0 KiB
Go

// Copyright (c) OpenFaaS Author(s). All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
package scaling
import (
"fmt"
"log"
)
type CachedFunctionQuery struct {
cache FunctionCacher
serviceQuery ServiceQuery
emptyAnnotations map[string]string
singleFlight *SingleFlight
}
func NewCachedFunctionQuery(cache FunctionCacher, serviceQuery ServiceQuery) FunctionQuery {
return &CachedFunctionQuery{
cache: cache,
serviceQuery: serviceQuery,
emptyAnnotations: map[string]string{},
singleFlight: NewSingleFlight(),
}
}
func (c *CachedFunctionQuery) GetAnnotations(name string, namespace string) (annotations map[string]string, err error) {
res, err := c.Get(name, namespace)
if err != nil {
return c.emptyAnnotations, err
}
if res.Annotations == nil {
return c.emptyAnnotations, nil
}
return *res.Annotations, nil
}
func (c *CachedFunctionQuery) Get(fn string, ns string) (ServiceQueryResponse, error) {
query, hit := c.cache.Get(fn, ns)
if !hit {
key := fmt.Sprintf("GetReplicas-%s.%s", fn, ns)
queryResponse, err := c.singleFlight.Do(key, func() (interface{}, error) {
log.Printf("Cache miss - run GetReplicas")
// If there is a cache miss, then fetch the value from the provider API
return c.serviceQuery.GetReplicas(fn, ns)
})
log.Printf("Result: %v %v", queryResponse, err)
if err != nil {
return ServiceQueryResponse{}, err
}
if queryResponse != nil {
c.cache.Set(fn, ns, queryResponse.(ServiceQueryResponse))
}
} else {
return query, nil
}
// At this point the value almost certainly must be present, so if not
// return an error.
query, hit = c.cache.Get(fn, ns)
if !hit {
return ServiceQueryResponse{}, fmt.Errorf("error with cache key: %s", fn+"."+ns)
}
return query, nil
}
type FunctionQuery interface {
Get(name string, namespace string) (ServiceQueryResponse, error)
GetAnnotations(name string, namespace string) (annotations map[string]string, err error)
}