From a574a0c06faf3ac6f6530d6c177c6a9fa7b0ab4a Mon Sep 17 00:00:00 2001 From: mohammadVatandoost Date: Thu, 14 Apr 2022 18:21:20 +0430 Subject: [PATCH] remove unused container client from createTask Signed-off-by: mohammadVatandoost Signed-off-by: Mohammad Vatandoost --- pkg/provider/handlers/deploy.go | 4 ++-- pkg/provider/handlers/scale.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/provider/handlers/deploy.go b/pkg/provider/handlers/deploy.go index a0c174c..8a1ec3a 100644 --- a/pkg/provider/handlers/deploy.go +++ b/pkg/provider/handlers/deploy.go @@ -175,7 +175,7 @@ func deploy(ctx context.Context, req types.FunctionDeployment, client *container return fmt.Errorf("unable to create container: %s, error: %w", name, err) } - return createTask(ctx, client, container, cni) + return createTask(ctx, container, cni) } @@ -203,7 +203,7 @@ func buildLabels(request *types.FunctionDeployment) (map[string]string, error) { return labels, nil } -func createTask(ctx context.Context, client *containerd.Client, container containerd.Container, cni gocni.CNI) error { +func createTask(ctx context.Context, container containerd.Container, cni gocni.CNI) error { name := container.ID() diff --git a/pkg/provider/handlers/scale.go b/pkg/provider/handlers/scale.go index 725341c..ee8c941 100644 --- a/pkg/provider/handlers/scale.go +++ b/pkg/provider/handlers/scale.go @@ -131,7 +131,7 @@ func MakeReplicaUpdateHandler(client *containerd.Client, cni gocni.CNI) func(w h } if createNewTask { - deployErr := createTask(ctx, client, ctr, cni) + deployErr := createTask(ctx, ctr, cni) if deployErr != nil { log.Printf("[Scale] error deploying %s, error: %s\n", name, deployErr) http.Error(w, deployErr.Error(), http.StatusBadRequest)